pgsql: Repair bug #2839: the various ExecReScan functions need to reset

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Repair bug #2839: the various ExecReScan functions need to reset
Date: 2006-12-26 19:27:26
Message-ID: 20061226192726.5F82C9FA2D4@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Repair bug #2839: the various ExecReScan functions need to reset
ps_TupFromTlist in plan nodes that make use of it. This was being done
correctly in join nodes and Result nodes but not in any relation-scan nodes.
Bug would lead to bogus results if a set-returning function appeared in the
targetlist of a subquery that could be rescanned after partial execution,
for example a subquery within EXISTS(). Bug has been around forever :-(
... surprising it wasn't reported before.

Tags:
----
REL7_3_STABLE

Modified Files:
--------------
pgsql/src/backend/executor:
nodeFunctionscan.c (r1.12 -> r1.12.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeFunctionscan.c.diff?r1=1.12&r2=1.12.2.1)
nodeIndexscan.c (r1.71 -> r1.71.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeIndexscan.c.diff?r1=1.71&r2=1.71.2.1)
nodeResult.c (r1.21 -> r1.21.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeResult.c.diff?r1=1.21&r2=1.21.2.1)
nodeSeqscan.c (r1.37 -> r1.37.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSeqscan.c.diff?r1=1.37&r2=1.37.2.1)
nodeSubqueryscan.c (r1.13 -> r1.13.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSubqueryscan.c.diff?r1=1.13&r2=1.13.2.1)
nodeTidscan.c (r1.26 -> r1.26.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeTidscan.c.diff?r1=1.26&r2=1.26.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-12-26 21:37:20 pgsql: Fix failure due to accessing an already-freed tuple descriptor in
Previous Message Tom Lane 2006-12-26 19:27:20 pgsql: Repair bug #2839: the various ExecReScan functions need to reset