| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: gratuituous string difference |
| Date: | 2006-11-29 19:44:52 |
| Message-ID: | 20061129194452.GB7001@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > This patch fixes a gratuituous string difference. Barring objections
> > I'll apply shortly.
>
> I object. We do not quote the output of format_type_be() ... look at
> its code to see why not.
Oh, I see -- it may add double quotes on its own in certain cases, while
the other string gets the input from TypeNameToString which never does.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2006-11-29 19:47:26 | -HEAD configure issue with libedit on linux |
| Previous Message | Tom Lane | 2006-11-29 19:42:53 | Re: [HACKERS] VPATH problems in ECPG again |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-11-29 19:50:12 | Re: More vcbuild |
| Previous Message | Tom Lane | 2006-11-29 19:42:53 | Re: [HACKERS] VPATH problems in ECPG again |