pgsql: expression_tree_walker failed to let walker function see the

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: expression_tree_walker failed to let walker function see the
Date: 2006-10-25 22:11:32
Message-ID: 20061025221132.AE1749FA136@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
expression_tree_walker failed to let walker function see the immediate child
node of a SubLink or SubPlan testexpr field. Bug resulted from replacing
the old lefthand/exprs list fields with a simple expression field, and not
remembering that expression_tree_walker is coded to save a few cycles by
recursing directly to self on list fields (on the assumption the walker
isn't interested in List nodes per se). On non-list fields it must of
course call the walker. Possibly that hack isn't worth the risk of more
such bugs, but I'll leave it be for now. Per bug report from James Robinson.

Modified Files:
--------------
pgsql/src/backend/optimizer/util:
clauses.c (r1.222 -> r1.223)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/clauses.c.diff?r1=1.222&r2=1.223)

Browse pgsql-committers by date

  From Date Subject
Next Message User Doudou586 2006-10-26 00:42:26 press - pr: Fixed laser's email
Previous Message User Okbob 2006-10-25 16:09:32 orafce - orafce: replace not necessery stable attr with immutable