| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Devrim GUNDUZ <devrim(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Markus Schaber <schabi(at)logix-tt(dot)com>, "pgsqlrpms-hackers(at)pgfoundry(dot)org" <pgsqlrpms-hackers(at)pgfoundry(dot)org> |
| Subject: | Re: Multiple postmaster + RPM + locale issues |
| Date: | 2006-10-20 14:29:54 |
| Message-ID: | 20061020142954.GB6718@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > ISTM these parts of that patch should be applied to our code:
>
> > +--- postgresql-8.1beta3-old/src/bin/pg_controldata/pg_controldata.c 2005-10-03 02:28:41.000000000 +0200
> > ++++ postgresql-8.1beta3/src/bin/pg_controldata/pg_controldata.c 2005-10-13 18:00:42.000000000 +0200
> > +@@ -73,7 +73,7 @@
> > + char *strftime_fmt = "%c";
> > + const char *progname;
> > +
> > +- set_pglocale_pgservice(argv[0], "pg_controldata");
> > ++ set_pglocale_pgservice(argv[0], "pg_controldata-8.1");
>
> Egad. What an ugly, unmaintainable crock.
Well, we could certainly not use it in the same form, but with a macro,
making it more future-proof.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Darcy Buskermolen | 2006-10-20 15:00:32 | misbehaving planer? |
| Previous Message | Tom Lane | 2006-10-20 14:25:48 | Re: Multiple postmaster + RPM + locale issues |