Re: Problems with extended-Query logging code

From: Abhijit Menon-Sen <ams(at)oryx(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Problems with extended-Query logging code
Date: 2006-09-07 00:56:46
Message-ID: 20060907005646.GA28998@penne.toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2006-09-06 18:01:38 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>
> That is, we'd log a Parse or Bind operation if it individually
> exceeded the duration threshold, and not otherwise.

Ok.

> If we've got support for logging the statement text and the parameter
> values at Execute time, isn't logging the preliminary steps just
> bloating the log?

Agreed. Logging Parse/Bind only if they're particularly interesting
sounds good to me.

> * I think that the best way to log bind-parameter values is to run the
> datatype output functions on the saved parameter values. This works
> whether they were sent in text or binary mode, and avoids any extra
> overhead at Bind time that might not be repaid.

Great. (The logging of binary parameters is something I also... not
exactly _need_, but would be happy about.)

-- ams

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2006-09-07 01:14:38 Re: gBorg status?
Previous Message Gavin Sherry 2006-09-07 00:38:32 Re: Timezone List