| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | bruce(at)momjian(dot)us |
| Cc: | Susanne Ebrecht <miracee(at)miracee(dot)de>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-patches(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org>, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [HACKERS] extension for sql update |
| Date: | 2006-09-03 00:46:19 |
| Message-ID: | 200609030046.k830kJg25624@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
bruce wrote:
> I have merged your patch into current CVS and applied it; attached.
> There was quite a bit of code drift. One drift area was the new
> RETURNING clause; that was easy to fix. A more complex case is the
> code no longer has values as ResTargets --- it is a simple a_expr list,
> so I changed the critical assignment in gram.y from:
>
> res_col->val = (Node *)copyObject(res_val->val);
>
> to:
>
> res_col->val = (Node *)copyObject(res_val);
>
> Hope that is OK. Without that fix, it crashed. I also merged your SGML
> syntax and grammer addition into the exiting UPDATE main entry.
The copyObject() is not required. Removed.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-09-03 00:56:33 | Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8. |
| Previous Message | Bruce Momjian | 2006-09-02 23:58:35 | Re: Backend SSL configuration enhancement |