Re: PATCH to allow concurrent VACUUMs to not lock each

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Hannu Krosing <hannu(at)skype(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: PATCH to allow concurrent VACUUMs to not lock each
Date: 2006-07-30 18:11:42
Message-ID: 20060730181142.GA8703@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
>
> Alvaro has just applied a modified version of this patch.

Hannu, I'm curious:

> Hannu Krosing wrote:

> > Ok, this is a new version of the vacuum patch with the following changes
> > following some suggestions in this thread.
> >
> > * changed the patch to affect only lazy vacuum
> > * moved inVacuum handling to use PG_TRY
> > * moved vac_update_relstats() out of lazy_vacuum_rel into a separate
> > transaction. The code to do this may not be the prettiest, maybe it
> > should use a separate struct.

What was idea behind moving vac_update_relstats to a separate
transaction? I'm wondering if it's still needed, if it further enhances
the system somehow, or your patch did something differently than what
was applied.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey E. Koposov 2006-07-30 18:13:46 Re: Do we need multiple forms of the SQL2003 statistics
Previous Message Tom Lane 2006-07-30 17:15:41 Re: [PATCHES] 8.2 features?

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2006-07-30 18:21:36 Re: [PATCHES] 8.2 features?
Previous Message Tom Lane 2006-07-30 17:15:41 Re: [PATCHES] 8.2 features?