From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to mark items as static or not used |
Date: | 2006-07-15 15:18:07 |
Message-ID: | 20060715151807.GA2467@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Sat, Jul 15, 2006 at 09:34:57AM -0400, Andrew Dunstan wrote:
> Neil Conway wrote:
> >We could annotate the source to indicate that some functions are
> >deliberately intended to be externally visible, but not referenced
> >within the source tree, and then teach find_static to grok that
> >annotation.
>
> I thought of that, but what if one gets missed? Is the tool worth the
> hassle?
The tool is just a tool. The annotation is so that some human won't
come to the conclusion that it can be removed. Teaching the tool to
skip it is just a bonus.
Some places mark external functions with DLLEXPORT but I guess we could
invent a comment that would be machine readable.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-07-15 15:27:14 | pgsql: Fix some pgcrypto portability issues, per Marko Kreen. |
Previous Message | Andrew Dunstan | 2006-07-15 13:34:57 | Re: Patch to mark items as static or not used |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-07-15 15:28:42 | Re: [PATCHES] [patch 0/9] annual pgcrypto update |
Previous Message | Andrew Dunstan | 2006-07-15 13:34:57 | Re: Patch to mark items as static or not used |