Re: [COMMITTERS] pgsql: Disallow changing/dropping default expression

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [COMMITTERS] pgsql: Disallow changing/dropping default expression
Date: 2006-06-27 03:53:38
Message-ID: 200606270353.k5R3rce01387@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Disallow changing/dropping default expression of a SERIAL column
>
> Wasn't this patch rejected? Your summary is utterly wrong about what
> it does, which makes me wonder whether you reviewed it at all. One
> would also think that a change in user-visible behavior would merit
> at least some documentation diffs.

Well, it seemed it controlled whether dependency allowed you do drop a
default sequence for a table. There is something I didn't like about
the patch now that I look at it again --- it uses constants 0-2 when it
should use defines or something clearer.

I thought we had decided that we could not make SERIAL just a macro, and
therefore we have to restrict how we allow modifications. If someone
wants total control, they should create the DEFAULT manually, but SERIAL
was going to be hard-wired.

Anyway, what is your opinion on this?

Yea, agreed on the documentation issue. That SERIAL distinction, if
that is the direction we are going, should be documented.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2006-06-27 03:56:57 Re: [COMMITTERS] pgsql: Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table
Previous Message Tom Lane 2006-06-27 03:46:18 Re: pgsql: Disallow changing/dropping default expression of a SERIAL column

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2006-06-27 03:56:57 Re: [COMMITTERS] pgsql: Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table
Previous Message Tom Lane 2006-06-27 03:46:18 Re: pgsql: Disallow changing/dropping default expression of a SERIAL column