Re: [HACKERS] Overhead for stats_command_string et al, take

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Overhead for stats_command_string et al, take
Date: 2006-06-26 23:31:51
Message-ID: 200606262331.k5QNVpP16347@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > If you put a contition test in set_ps_display(), the only clean way to
> > do this is for init_ps_display() to force update_process_title to true
> > before we call set_ps_display(), then reset it to its original value,
> > but that sounds pretty ugly.
>
> No, refactor the code. I was envisioning something called maybe
> transmit_ps_display that would contain the part of set_ps_display
> beginning at "Transmit new setting to kernel". Then both set_ps_display
> and init_ps_display would call that.

I went with a 'force' boolean for set_ps_display().

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/no_title text/x-diff 17.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-06-27 00:03:30 Re: [HACKERS] PQescapeIdentifier
Previous Message Tom Lane 2006-06-26 22:08:38 Re: [HACKERS] Overhead for stats_command_string et al, take 2

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-06-27 00:03:30 Re: [HACKERS] PQescapeIdentifier
Previous Message Tom Lane 2006-06-26 22:08:38 Re: [HACKERS] Overhead for stats_command_string et al, take 2