Skip site navigation (1) Skip section navigation (2)

Re: Patch for - Allow server logs to be remotely read

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Dhanaraj(dot)M(at)Sun(dot)COM, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for - Allow server logs to be remotely read
Date: 2006-06-08 14:51:14
Message-ID: 200606081451.k58EpEp25782@candle.pha.pa.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> I wonder if we should take pg_read_file (and the rest of genfile.c)
> >> back out of the backend and stick them into contrib/adminpack.
> 
> > I thought about that but what we have in the backend now is read-only
> > which basically could be done using COPY, so I don't see any security
> > value to moving them out.  They are super-user only just like COPY.
> 
> The you-can-do-it-with-COPY argument doesn't apply to pg_ls_dir, nor to
> pg_stat_file, and I find it unconvincing even for pg_read_file.  COPY
> isn't at all friendly for trying to read binary files, for instance.
> Even for plain ASCII text you'd have to try to find a delimiter
> character not present anywhere in the file, and backslashes in the file
> would get corrupted.
> 
> But the basic point here is that someone who wants filesystem access
> from the database is going to install adminpack anyway.  Why should
> someone who *doesn't* want filesystem access from the database be
> forced to have some capabilities of that type installed anyway?

Remember we went around and around on this with the pgAdmin guys, so you
are going to have to get their input.  Also consider that pgAdmin might
be doing remote administration on a database it can't load shared
objects into, so having the read stuff always be there might help them.

I don't see anyone complaining about our read-only file access in the
backend, so I don't see a readon to remove it.

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-06-08 15:08:05
Subject: Removing unreferenced files
Previous:From: Tom LaneDate: 2006-06-08 14:36:38
Subject: Re: Patch for - Allow server logs to be remotely read

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group