Re: [PORTS] solaris build problem with Sun compilers

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Theo Schlossnagle <jesus(at)omniti(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alan Stange <stange(at)rentec(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PORTS] solaris build problem with Sun compilers
Date: 2006-05-18 18:52:21
Message-ID: 200605181852.k4IIqLd16624@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Theo Schlossnagle wrote:
>
> On May 18, 2006, at 11:56 AM, Bruce Momjian wrote:
>
> > Theo Schlossnagle wrote:
> >>
> >> On May 17, 2006, at 8:30 PM, Bruce Momjian wrote:
> >>
>
> [ snip ]
>
> >>> OK, so what do you suggest? Remove that URL from the comments?
> >>> Anything else?
> >>
> >> If you compile with -xarch=v8plus you should be able to omit the
> >> #ifdef's entirely. The sparcv8plus and sparcv9 cas instruction are
> >> identical. Is the goal here to support Sparc chips that do not
> >> support the v8plus instruction set? I'm not on the ports list, so
> >> maybe I missed the original problem report.
> >
> > We don't actually know all the Solaris versions/hardware we should
> > support, so it is hard to say if we currently have running sparcv8
> > CPUs.
> > The best solution is to use separate entries for v8 and v9. Is
> > there a
> > unique preprocessor symbol when a sparcv8plus binary is being
> > generated?
>
> Heh.. you could likely guess it:
> #if defined(__sparcv8plus)

Nice, comments and macro tests updated. New version of file attached.

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
unknown_filename text/plain 1.2 KB

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-05-18 19:18:12 Re: [GENERAL] Querying libpq compile time options
Previous Message Bruce Momjian 2006-05-18 17:51:00 Re: [PATCHES] small doc patch for regexp_replace