pgsql: Fix thinko in recent changes to handle ScalarArrayOpExpr as an

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix thinko in recent changes to handle ScalarArrayOpExpr as an
Date: 2006-05-18 17:12:10
Message-ID: 20060518171210.F268B9FA48C@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix thinko in recent changes to handle ScalarArrayOpExpr as an indexable
condition: when there are multiple possible index paths involving
ScalarArrayOpExprs, they are logically to be ANDed together not ORed.
This thinko was a direct consequence of trying to put the processing
inside generate_bitmap_or_paths(), which I now see was a bit too cute.
So pull it out and make the callers do it separately (there are only two
that need it anyway). Partially responds to bug #2441 from Arjen van der Meijden.
There are some additional infelicities exposed by his example, but they
are also in 8.1.x, while this mistake is not.

Modified Files:
--------------
pgsql/src/backend/optimizer/path:
indxpath.c (r1.204 -> r1.205)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/indxpath.c.diff?r1=1.204&r2=1.205)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2006-05-18 18:19:47 pgsql: Code alignment fix.
Previous Message Bruce Momjian 2006-05-18 16:26:44 pgsql: Remove canonicalize_path() call for .pgpass socket directory