Re: [PATCH] Add support for GnuTLS

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Add support for GnuTLS
Date: 2006-05-06 19:21:29
Message-ID: 20060506192129.GE4413@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sat, May 06, 2006 at 02:47:33PM -0400, Bruce Momjian wrote:
> Martijn van Oosterhout wrote:
> > If you like I can split it into two patches, one patch splits the openssl
> > stuff out of the main files and a second which adds gnutls support.
>
> Yes, I understood that, but we now have duplicate files for secure
> connections, meaning we have double maintenance in some cases.

Hmm, I see your point. I guess that's an unavoidable side-effect of the
process :(. However, judging from the CVS logs, these have not been files
with a high change rate. I think it's worth it but I can imagine other
people see that differently.

There is not a lot of code can be shared. What can be already is eg.
prepare_for_client_read and client_read_ended, the names of the files
used, EPIPE handling, etc.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2006-05-06 20:29:29 Re: Page at a time index scan
Previous Message Bruce Momjian 2006-05-06 18:47:33 Re: [PATCH] Add support for GnuTLS