Re: pg_ctl options checking

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_ctl options checking
Date: 2006-04-17 19:14:27
Message-ID: 200604171914.k3HJERH02366@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch rejected due to user complaints.

---------------------------------------------------------------------------

Simon Riggs wrote:
> pg_ctl: Minor patch to implement option checking to prevent silently
> ignoring options and continuing with defaults.
>
> All of the following now cause errors:
>
> pg_ctl -D test -m logfile start
> pg_ctl -D test -U foo start
> pg_ctl -D test -W start
> pg_ctl -D test -w stop
> pg_ctl -D test -l fast stop
> etc.. (16 possible error combinations in total now checked)
>
> The following also fails, following the --help, though I think we might
> want to change this so that it does actually work:
>
> pg_ctl -D test -l logfile restart
>
> Patch against cvstip, make check, tested on long and short options.
>
> --
> Simon Riggs
> EnterpriseDB http://www.enterprisedb.com

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Sven Suursoho 2006-04-17 20:26:07 Re: plpython improvements
Previous Message Tom Lane 2006-04-17 19:12:21 Re: pg_ctl options checking