Re: [WIP] Add relminxid column to pg_class

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [WIP] Add relminxid column to pg_class
Date: 2006-04-09 20:43:20
Message-ID: 20060409204320.GA16673@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Alvaro Herrera wrote:
> Tom Lane wrote:
>
> > I'd argue that you should do nothing, ie, dropping a table should never
> > affect datminxid. The proper interpretation of the pg_database columns
> > is that we guarantee that all XID's in the database are *at least* thus-
> > and-so, not that the minimum is exact.
>
> Ok, this new patch does this. It allowed to simplify some code a bit,
> and works wonderfully.

BTW, I forgot to mention that I intend to apply this patch later today,
regardless of whatever solution we may decide for the problem below; we
can add it later, and it certainly is a corner case.

> The solution seems to be to vacuum the whole database right after
> cloning. Or to forcibly set the pg_class value to the current
> TransactionId, without vacuuming (which should be fine, because the
> template database was frozen).

Another possibility is to have autovac vacuum all databases, including
those marked not connectable. While this won't solve the problem for
those not running autovac, chances are that people doing so will be less
with each release.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Luke Lonergan 2006-04-09 20:51:50 Re: Support Parallel Query Execution in Executor
Previous Message Gregory Maxwell 2006-04-09 20:36:54 Re: Support Parallel Query Execution in Executor