pgsql: Fix plpgsql to pass only one copy of any given plpgsql variable

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix plpgsql to pass only one copy of any given plpgsql variable
Date: 2006-03-23 04:22:37
Message-ID: 20060323042237.42D299DCB78@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL
command or expression, rather than one copy for each textual occurrence as
it did before. This might result in some small performance improvement,
but the compelling reason to do it is that not doing so can result in
unexpected grouping failures because the main SQL parser won't see different
parameter numbers as equivalent. Add a regression test for the failure case.
Per report from Robert Davidson.

Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
gram.y (r1.87 -> r1.88)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/gram.y.diff?r1=1.87&r2=1.88)
pgsql/src/test/regress/expected:
plpgsql.out (r1.44 -> r1.45)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plpgsql.out.diff?r1=1.44&r2=1.45)
pgsql/src/test/regress/sql:
plpgsql.sql (r1.37 -> r1.38)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/plpgsql.sql.diff?r1=1.37&r2=1.38)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-03-23 04:22:45 pgsql: Fix plpgsql to pass only one copy of any given plpgsql variable
Previous Message User Nwakefield 2006-03-23 01:57:10 bizgres - bizgres: added suport for moving and deleting the source file