Re: Proposed p.tch for error locations

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Glaesemann <grzm(at)myrealbox(dot)com>, pgsql-patches(at)postgreSQL(dot)org, pgsql-interfaces(at)postgreSQL(dot)org
Subject: Re: Proposed p.tch for error locations
Date: 2006-03-13 16:03:35
Message-ID: 20060313160335.GN8274@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces pgsql-patches

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > This doesn't work on terminal using a variable-width font, does it?
> > Sure, you can have all the interfaces use a monospace font, but it seems
> > a weird thing to do. I think the line/character position should be
> > returned in a separate error attribute in ereport. So for example
> > pgAdmin could count characters and mark it in bold or use a different
> > color.
>
> That information is already available to pgAdmin, and has been since
> 7.4; if they are failing to exploit it that's their problem not libpq's.

Aye, that's fine. I don't really know if pgAdmin uses the info or not.
I thought the proposal to remove the "at character N" in the error
message meant that the only way to get that information would be from
the "LINE Y: ...\n[some whitespace]^" message, which would be pretty
cumbersome. But if there already is a field in the error message for
the position, then nothing is lost.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message Tom Lane 2006-03-13 16:08:30 Re: Proposed p.tch for error locations
Previous Message Tom Lane 2006-03-13 15:57:07 Re: Proposed p.tch for error locations

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2006-03-13 16:07:48 Re: CREATE SYNONYM ...
Previous Message Tom Lane 2006-03-13 15:57:07 Re: Proposed p.tch for error locations