Re: [HACKERS] Zeroing damaged pages

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Zeroing damaged pages
Date: 2006-03-07 03:12:00
Message-ID: 200603070312.k273C0R20398@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
> > + /* Even if zero_damaged_pages is true, we don't want autovacuum zeroing. */
> > + zero_damaged_pages = false;
>
> This is completely incorrect; you need to set the variable via GUC, else
> it will still be overridden from postgresql.conf if a SIGHUP arrives.
> I believe this would work:
>
> SetConfigOption("zero_damaged_pages", "false",
> PGC_SUSET, PGC_S_SESSION);

Done.

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-03-07 03:18:56 Re: [PATCHES] implement prepared queries in plperl
Previous Message Tom Lane 2006-03-07 03:10:25 Re: Plan for resetting commented postgresql.conf vars at sighup

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-03-07 03:18:56 Re: [PATCHES] implement prepared queries in plperl
Previous Message Tom Lane 2006-03-07 01:38:58 Re: [HACKERS] Zeroing damaged pages