Re: pgsql: * Stephen Frost (sfrost@snowman.net) wrote:

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> >> I've now tested this patch at home w/ 8.2HEAD and it seems to fix the
> >> bug. I plan on testing it under 8.1.2 at work tommorow with
> >> mod_auth_krb5, etc, and expect it'll work there. Assuming all goes
> >> well and unless someone objects I'll forward the patch to -patches.
> >> It'd be great to have this fixed as it'll allow us to use Kerberos to
> >> authenticate to phppgadmin and other web-based tools which use
> >> Postgres.
>
> > While playing with this patch under 8.1.2 at home I discovered a
> > mistake in how I manually applied one of the hunks to fe-auth.c.
> > Basically, the base code had changed and so the patch needed to be
> > modified slightly. This is because the code no longer either has a
> > freeable pointer under 'name' or has 'name' as NULL.
>
> > The attached patch correctly frees the string from pg_krb5_authname
> > (where it had been strdup'd) if and only if pg_krb5_authname returned
> > a string (as opposed to falling through and having name be set using
> > name = pw->name;). Also added a comment to this effect.
>
> Bruce, people would appreciate it if you made some effort to ensure
> that commit messages describe the main purposes of the patch, rather
> than being just the verbatim text of the last message in the thread.
> The above log message is not merely overly verbose, but completely
> useless. One might guess that the change had something to do with
> Kerberos, but what?

First I am hearing a complaint. I will try to clean them up.

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +