Re: [HACKERS] how solve diff of API counstruct_md_array between

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Joe Conway <mail(at)joeconway(dot)com>, Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>
Subject: Re: [HACKERS] how solve diff of API counstruct_md_array between
Date: 2006-02-28 18:24:31
Message-ID: 200602281824.k1SIOVl12211@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Bruce Momjian wrote:
> >> OK, updated version of the patch attached and applied.
>
> > I still object to this. What is wrong with using the catalog version
> > number?
>
> It's partially redundant, but only partially, and I agree that it'll
> probably be easier for people to use than the catversion number.
>
> The case where it's not redundant would be if an add-on needs to deal
> with an internal API change made in a sub-release, e.g. 8.1.4, where
> the catversion number is not going to change. We've certainly done that
> before and will do so again, when there's no other way to fix a bug.

Also, that macro block where Joe Conway compared catalog version numbers
and defined understandable macro names cried out for a solution.

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-02-28 18:30:44 Re: [HACKERS] how solve diff of API counstruct_md_array between
Previous Message Kevin Grittner 2006-02-28 18:16:50 Re: [PERFORM] temporary indexes

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-02-28 18:30:44 Re: [HACKERS] how solve diff of API counstruct_md_array between
Previous Message Tom Lane 2006-02-28 17:30:46 Re: [HACKERS] how solve diff of API counstruct_md_array between