Re: [HACKERS] Patch Submission Guidelines

Tom Lane wrote:
> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> > On Thursday 16 February 2006 00:27, Tom Lane wrote:
> >> * avoid unnecessary whitespace changes. They just distract the
> >> reviewer, and your formatting changes will probably not survive
> >> the next pgindent run anyway.
>
> > would diff -c --ignore-space-change be better?
>
> Hmm. Not sure --- there are situations where whitespace *does* matter,
> so having that as a blanket policy doesn't seem wise. Also I'm worried
> that a diff made this way would confuse patch (for instance, because
> line numbers following an omitted whitespace change wouldn't match up).
> Probably best not to go there, but just focus on the point about keeping
> the patch readable.

Agreed. It isn't that we don't want whitespace changes, just that we
don't want insignificant whitespace changes.

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +