From: | Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Patch Submission Guidelines |
Date: | 2006-02-16 12:17:51 |
Message-ID: | 200602160717.51864.xzilla@users.sourceforge.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Thursday 16 February 2006 00:27, Tom Lane wrote:
> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> > ! <li>The patch should be generated in contextual diff format and
> > should ! be applicable from the root directory. If you are unfamiliar
> > with ! this, you might find the script
> > <I>src/tools/makediff/difforig</I> ! useful. Unified diffs are only
> > preferrable if the file changes are ! single-line changes and do not
> > rely on the surrounding lines.</li>
>
> I'd like the policy to be "contextual diffs are preferred", full stop.
> Unidiffs are more compact but they sacrifice readability of the patch
> (IMHO anyway) and when you are preparing a patch you should be thinking
> first in terms of making it readable for the reviewers/committers.
>
> Some things that follow along with the readability mandate, and should
> be brought out somewhere here:
> * avoid unnecessary whitespace changes. They just distract the
> reviewer, and your formatting changes will probably not survive
> the next pgindent run anyway.
would diff -c --ignore-space-change be better?
> * try to follow the project's code-layout conventions; again, this
> makes it easier for the reviewer, and there's no long-term point
> in trying to do it differently than pgindent would.
>
--
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL
From | Date | Subject | |
---|---|---|---|
Next Message | Dhanaraj | 2006-02-16 12:37:25 | Doubt in parser |
Previous Message | Florian Weimer | 2006-02-16 12:10:48 | Re: qsort again |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2006-02-16 14:38:26 | Re: Patch Submission Guidelines |
Previous Message | Tom Lane | 2006-02-16 05:27:40 | Re: [HACKERS] Patch Submission Guidelines |