From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Kris Jurka <books(at)ejurka(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
Date: | 2006-02-10 16:58:12 |
Message-ID: | 20060210165812.GB576@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-patches |
On Fri, Feb 10, 2006 at 11:02:41AM -0500, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I have applied your patch to psql and Teodor has adjusted the
> > tsearch2 expected results. I can't seem to run pgcrypto without getting
> > PRNG errors, so I expect my SSL is too old. Would you send me your
> > pgcrypto/regression.diff? Thanks.
>
> I fixed that already. Please see about fixing the compiler warnings you
> introduced. On a 64-bit machine there are even more, and the int vs
> size_t ones are definitely portability problems.
Ouch. I submitted this patch so long ago I figured it'd gotten lost. I
was actually considering preparing a new version against HEAD.
I'll try to address these warnings (unless someone beats me to it).
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-02-10 16:59:58 | Re: [COMMITTERS] pgsql: Allow psql multi-line column values |
Previous Message | Bruce Momjian | 2006-02-10 16:28:34 | Re: pgsql: Allow psql multi-line column values to align |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-02-10 16:58:33 | Re: Scrollable cursors and Sort performance |
Previous Message | Simon Riggs | 2006-02-10 16:48:42 | Re: Scrollable cursors and Sort performance |