Re: pg_restore COPY error handling

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_restore COPY error handling
Date: 2006-01-28 16:27:47
Message-ID: 20060128162747.GF4474@ns.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce, et al,

* Bruce Momjian (pgman(at)candle(dot)pha(dot)pa(dot)us) wrote:
> This needs a little style cleanup but I can do that.

Thanks!

> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.

Great! It'd be really nice to have this fix in 8.1.3... :)

Thanks again,

Stephen

> ---------------------------------------------------------------------------
> Stephen Frost wrote:
> > * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > > Needs to be changed to handle whitespace in front of the actual 'COPY',
> > > unless someone else has a better idea. This should be reasonably
> > > trivial to do though... If you'd like me to make that change and send
> > > in a new patch, just let me know.
> >
> > Fixed, using isspace(). Also added an output message to make it a bit
> > clearer when a failed COPY has been detected, etc.
> >
> > Updated patch attached.
> >
> > Thanks,
> >
> > Stephen
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Have you searched our list archives?
> >
> > http://archives.postgresql.org
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Woodward 2006-01-29 18:21:21 Want to add to contrib.... xmldbx
Previous Message Andrew Dunstan 2006-01-28 16:26:33 Re: plperl / locale / win32