pgsql: mbutils was previously doing some allocations, including invoking

From: neilc(at)postgresql(dot)org (Neil Conway)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: mbutils was previously doing some allocations, including invoking
Date: 2006-01-12 22:04:02
Message-ID: 20060112220402.B45F29DC995@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
mbutils was previously doing some allocations, including invoking
fmgr_info(), in the TopMemoryContext. I couldn't see that the code
actually leaked, but in general I think it's fragile to assume that
pfree'ing an FmgrInfo along with its fn_extra field is enough to
reclaim all the resources allocated by fmgr_info(). I changed the
code to do its allocations in a new child context of
TopMemoryContext, MbProcContext. When we want to release the
allocations we can just reset the context, which is cleaner.

Modified Files:
--------------
pgsql/src/backend/utils/mb:
mbutils.c (r1.54 -> r1.55)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/mbutils.c.diff?r1=1.54&r2=1.55)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2006-01-12 22:15:57 pgsql: Clear up remaining compile warning for plperl on Windows.
Previous Message Tom Lane 2006-01-12 21:49:41 pgsql: Repair "Halloween problem" in EvalPlanQual: a tuple that's been