| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |
| Date: | 2019-01-03 19:22:36 |
| Message-ID: | 2005730.TFoJP5CCPs@x200m |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от четверг, 3 января 2019 г. 16:10:20 MSK пользователь Alvaro Herrera
написал:
> On 2019-Jan-02, Nikolay Shaplov wrote:
> > This is internal API, right? If we change it everywhere, then it is
> > changed and nothing will be broken?
>
> No, it's exported for extensions to use. If we change it unnecessarily,
> extension authors will hate me (not you) for breaking the compile and
> requiring an #if VERSION patch.
Ok, that's a good reason...
Can we think about backward compatibility aliases?
#define ViewHasCheckOption(relation) \
((relation)->rd_options && \
((ViewOptions *) (relation)->rd_options)->check_option_offset != 0)
/* Alias for backward compatibility */
#define RelationHasCheckOption(relation) ViewHasCheckOption(relation)
And keep them for as log as needed to avoid #if VERSION in thirdparty code?
Or that is not the case?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Ramsey | 2019-01-03 19:59:39 | Re: Changing SQL Inlining Behaviour (or...?) |
| Previous Message | Alvaro Herrera | 2019-01-03 19:10:20 | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |