Re: TODO item: list prepared queries

daveg wrote:
> On Fri, Dec 30, 2005 at 05:55:23PM -0500, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Neil Conway <neilc(at)samurai(dot)com> writes:
> > > > One minor irritation is that the query string of prepared statements
> > > > created via SQL has "PREPARE ... AS" prefixed to it, whereas statements
> > > > prepared via the FE-BE protocol do not. This should probably be fixed,
> > >
> > > That's debatable. Earlier today, I was busy being annoyed all over
> > > again with the way that Bruce set up Parse/Bind/Execute logging to
> > > deliberately obscure the difference between a SQL PREPARE command and a
> > > protocol-level Parse operation. I think it's a good thing to be able to
> > > tell which level a prepared statement came from. Yeah, much of the time
> > > you may not care, but when you do care it's important.
> >
> > I have applied the following patch to CVS HEAD to mark client-side
> > prepare/bind/execute statements with "[client]" so they can be easily
> > distinguished from SQL commands. I hesitate to apply this logging
> > change to 8.1.X.
>
> Could I suggest the reverse? That is, leave client statements alone and
> mark server side ones specially. It seems to me that "client" is the "normal"
> case and leaving it alone would be less intrusive.

Uh, the problem is that we don't normally mark SQL queries, so marking
only the server prepares and leaving the client prepares alone seems
inconsistent.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073