| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | ishii(at)sraoss(dot)co(dot)jp, pgman(at)candle(dot)pha(dot)pa(dot)us, sagi(at)adamnet(dot)co(dot)il, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 |
| Date: | 2005-12-24 00:27:23 |
| Message-ID: | 20051224.092723.123398431.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
> Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> writes:
> > I think the current implementaion in utf8_and_iso8859.c is fast but
> > too fragile against rearranging of encoding id. I modify those functions
> > in utf8_and_iso8859.c to do a linear search with encoding id.
>
> That's not unreasonable, but I was wondering whether we could add some
> Assert() tests that would catch problems without imposing any extra cost
> in normal non-Assert builds.
I thought about that too. But my conclusion was current code is too
hard to maintain even if appropreate comments are written in related
files.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tony | 2005-12-24 19:43:45 | BUG #2125: SELECT problem with strings containing \ |
| Previous Message | Tom Lane | 2005-12-23 22:38:05 | Re: horology regression test failure |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2005-12-24 11:22:31 | Re: default resource limits |
| Previous Message | Andrew Dunstan | 2005-12-23 23:58:22 | Re: [PATCHES] default resource limits |