| From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: When in transaction-aborted state, reject Bind message for |
| Date: | 2005-11-10 00:31:50 |
| Message-ID: | 20051110003150.DB624D9343@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
When in transaction-aborted state, reject Bind message for portals containing
anything but transaction-exiting commands (ROLLBACK etc). We already rejected
Parse and Execute in such cases, so there seems little point in allowing Bind.
This prevents at least an Assert failure, and probably worse things, since
there's a lot of infrastructure that doesn't work when not in a live
transaction. We can also simplify the Bind logic a bit by rejecting messages
with a nonzero number of parameters, instead of the former kluge to silently
substitute NULL for each parameter. Per bug #2033 from Joel Stevenson.
Tags:
----
REL8_0_STABLE
Modified Files:
--------------
pgsql/src/backend/tcop:
postgres.c (r1.440.4.3 -> r1.440.4.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.diff?r1=1.440.4.3&r2=1.440.4.4)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-11-10 00:32:00 | pgsql: When in transaction-aborted state, reject Bind message for |
| Previous Message | Tom Lane | 2005-11-10 00:31:41 | pgsql: When in transaction-aborted state, reject Bind message for |