pgsql: Repair an error introduced by log_line_prefix patch: it is not

Log Message:
-----------
Repair an error introduced by log_line_prefix patch: it is not acceptable
to assume that the string pointer passed to set_ps_display is good forever.
There's no need to anyway since ps_status.c itself saves the string, and
we already had an API (get_ps_display) to return it.
I believe this explains Jim Nasby's report of intermittent crashes in
elog.c when %i format code is in use in log_line_prefix.
While at it, repair a previously unnoticed problem: on some platforms such as
Darwin, the string returned by get_ps_display was blank-padded to the maximum
length, meaning that lock.c's attempt to append " waiting" to it never worked.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/backend/postmaster:
postmaster.c (r1.443.4.3 -> r1.443.4.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c.diff?r1=1.443.4.3&r2=1.443.4.4)
pgsql/src/backend/storage/lmgr:
lock.c (r1.145.4.1 -> r1.145.4.2)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/lock.c.diff?r1=1.145.4.1&r2=1.145.4.2)
pgsql/src/backend/utils/error:
elog.c (r1.155.4.3 -> r1.155.4.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/elog.c.diff?r1=1.155.4.3&r2=1.155.4.4)
pgsql/src/backend/utils/misc:
ps_status.c (r1.23 -> r1.23.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/ps_status.c.diff?r1=1.23&r2=1.23.4.1)
pgsql/src/include/libpq:
libpq-be.h (r1.49 -> r1.49.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/libpq/libpq-be.h.diff?r1=1.49&r2=1.49.4.1)
pgsql/src/include/utils:
ps_status.h (r1.25 -> r1.25.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/ps_status.h.diff?r1=1.25&r2=1.25.4.1)