Re: add_missing_from breaks existing views

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, andrew(at)supernews(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: add_missing_from breaks existing views
Date: 2005-10-26 18:16:01
Message-ID: 20051026181601.GC30351@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 26, 2005 at 11:41:56AM -0400, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Should we allow CREATE VIEW to run with "add_missing_from = true"
> > until we fix CREATE VIEW to handle this cleanly?
>
> No. Not only is that horridly ugly, it doesn't fix the problem,
> because CREATE VIEW is just one case (see also CREATE RULE). If we
> were to defeat add_missing_from for both, there wouldn't be much
> left of it at all. Going back to default-true would be far cleaner.

A VIEW that depends on add-missing-from is a clear case of pilot
error. We can document this, warn people, and turn it off by default.
Is there some fairly simple way to find VIEWs that have this property
so they can be fixed?

Cheers,
D
--
David Fetter david(at)fetter(dot)org http://fetter.org/
phone: +1 510 893 6100 mobile: +1 415 235 3778

Remember to vote!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2005-10-26 18:42:16 Re: [BUGS] BUG #1993: Adding/subtracting negative
Previous Message Grzegorz Piotr Jaskiewicz 2005-10-26 18:02:29 gist problem