| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer |
| Date: | 2005-10-22 09:50:32 |
| Message-ID: | 20051022095030.GA16589@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Oct 21, 2005 at 06:09:00PM -0400, Tom Lane wrote:
> BTW, we may be perfectly safe on architectures like PPC, where
> S_UNLOCK includes an __asm__ __volatile__ section for a hardware-level
> optimization fence instruction. I wonder though if it'd be a good idea
> to be marking those fence instructions with the "clobbers memory"
> qualifier to ensure this?
Judging by the comments in the linux kernel w.r.t their barrier()
instruction, there are certain versions of gcc that (incorrectly) do
strange things with the "volatile" tag of asm statements. Cloberring
memory is the way to guarentee what you want...
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User T-ishii | 2005-10-22 12:57:58 | pgpool - pgpool: Fix connection error when client_min_message is verbose |
| Previous Message | Tom Lane | 2005-10-21 22:09:00 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paresh Bafna | 2005-10-22 10:11:07 | Nested/recursive query execution |
| Previous Message | 7r00l (sent by Nabble.com) | 2005-10-22 09:45:32 | nabble.com |