From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ron Peacetree <rjpeace(at)earthlink(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PERFORM] A Better External Sort? |
Date: | 2005-10-04 15:23:41 |
Message-ID: | 20051004152336.GI17589@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-performance |
On Tue, Oct 04, 2005 at 03:56:53PM +0100, Simon Riggs wrote:
> I've been using gcc 3.4 and saw no warning when using either "-Winline"
> or "-O3 -Winline".
Ok, I've just installed 3.4 and verified that. I examined the asm code
and gcc is inlining it. I concede, at this point just throw in -Winline
and monitor the situation.
As an aside, the *_getattr calls end up a bit suboptimal though. It's
producing code like:
cmp attlen, 4
je $elsewhere1
cmp attlen, 2
je $elsewhere2
ld byte
here:
--- much later ---
elsewhere1:
ld integer
jmp $here
elsewhere2:
ld short
jmp $here
No idea whether we want to go down the path of hinting to gcc which
size will be the most common.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
From | Date | Subject | |
---|---|---|---|
Next Message | Zeugswetter Andreas DAZ SD | 2005-10-04 16:16:21 | Re: Inherited indexes. |
Previous Message | Tom Lane | 2005-10-04 15:10:18 | Re: Vacuum and Transactions |
From | Date | Subject | |
---|---|---|---|
Next Message | mark | 2005-10-04 17:02:53 | Re: [PERFORM] A Better External Sort? |
Previous Message | Tom Lane | 2005-10-04 15:01:59 | Re: [PERFORM] A Better External Sort? |