Re: [HACKERS] statement logging / extended query protocol

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Oliver Jowett <oliver(at)opencloud(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement logging / extended query protocol
Date: 2005-09-26 16:44:05
Message-ID: 200509261644.j8QGi5I14722@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

David Fetter wrote:
> On Sun, Sep 25, 2005 at 11:41:11PM -0400, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > OK. At this stage it should all just wait for 8.2.
> > >
> > > Haven't we already committed some feature changes in this area? I
> > > dislike the idea of shipping a transient state just because "we
> > > ran out of time". Once we ship 8.1, that will be another behavior
> > > that we have to consider backwards compatibility with. We should
> > > either fix it right, or revert to the 8.0 behavior for this
> > > release.
> >
> > I documented in TODO what doesn't log properly in 8.1. I don't see
> > how logging output has to be backward compatible.
>
> Dunno about this particular case, but not having backward-compatible
> logging output has already broken pqa. Proposal on logging to
> -hackers follows...

Yes, that is one area that is of concern for logging changes. What I
have done is to get minimal logging of the FETCH behavior into 8.1,
along with what we already have added in 8.1.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-09-26 16:48:19 Re: openbsd, plpython, missing threading symbols
Previous Message David Fetter 2005-09-26 16:31:16 Re: [HACKERS] statement logging / extended query protocol

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-09-26 16:58:04 Re: Patching dblink.c to avoid warning about open transaction
Previous Message David Fetter 2005-09-26 16:31:16 Re: [HACKERS] statement logging / extended query protocol