Re: pg_config/share_dir

From: Darcy Buskermolen <darcy(at)wavefire(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_config/share_dir
Date: 2005-09-08 15:33:29
Message-ID: 200509080833.30272.darcy@wavefire.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday 07 September 2005 17:31, Andrew Dunstan wrote:
> Darcy Buskermolen wrote:
> >On Wednesday 07 September 2005 15:52, Andrew Dunstan wrote:
> >>Peter Eisentraut wrote:
> >>>Andrew Dunstan wrote:
> >>>>pg_config doesn't currently seem to have an option to report the
> >>>>share_dir. Should it?
> >>>
> >>>Is there a case where a user would need anything from there?
> >
> >the way wo do this in slony is with the following macro:
> >
> >AC_MSG_CHECKING(for postgresql.conf.sample)
> >PGSHARE_POSSIBLE_LOCATIONS="${with_pgsharedir} /usr/local/pgsql/share
> > /usr/local/share/postgresql /usr/share/postgresql /usr/local/share/pgsql
> > /usr/share/pgsql /opt/local/pgsql/share /opt/pgsql/share
> > ${PG_BINDIR}/../share
> >for i in $PGSHARE_POSSIBLE_LOCATIONS; do
> > if test -s "$i/postgresql.conf.sample" ; then
> > PG_SHAREDIR=$i/
> > break;
> > fi
> >done
> >
> >if test -n "$PG_SHAREDIR" ; then
> > AC_MSG_RESULT(${PG_SHAREDIR}postgresql.conf.sample)
> > AC_DEFINE(PG_SHAREDIR_VERIFIED,1,[PostgreSQL sharedir])
> >else
> > AC_MSG_RESULT(not found)
> > AC_MSG_ERROR(
> > postgresql.conf.sample not found! Please specify the sharedir
> > with --with-pgsharedir=<dir>
> > )
> >fi
> >
> >
> >(where ${PG_BINDIR} is the result of: pg_config --bindir )
>
> That's foul, and looks horribly fragile too. You have just provided what
> seems to me a perfect use case.

Yes it is foul :-) but it's the best we could do given the tools we had to
work with..... which is precisely why we provide the failover to
-with-pgsharedir=<dir> incase the system can't get it right.

>
> cheers
>
> andrew
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Atkins 2005-09-08 15:49:10 Re: initdb profiles
Previous Message Darcy Buskermolen 2005-09-08 15:31:34 Re: pg_config/share_dir