Re: [HACKERS] Followup on the UnixWare Optimizer bug.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Followup on the UnixWare Optimizer bug.
Date: 2005-08-25 03:53:37
Message-ID: 200508250353.j7P3rbI16174@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Good catch on the memory leak. I have applied the following fix.
>
> These explicit pfrees are a waste of time, and probably actually
> counterproductive as far as speed goes, because these functions
> will always be invoked in relatively short-lived memory contexts.
>
> I wouldn't object except that they seem to make the code noticeably
> more obscure.

OK, patch reverted. I am often unsure where we do quick cleanup and
were we don't.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-08-25 04:37:24 Re: Followup on the UnixWare Optimizer bug.
Previous Message Tom Lane 2005-08-25 03:13:30 Re: TODO list comments

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-08-25 04:37:24 Re: Followup on the UnixWare Optimizer bug.
Previous Message Tom Lane 2005-08-25 02:39:27 Re: [HACKERS] Followup on the UnixWare Optimizer bug.