PL/Perl embedding string common elements

From: Michael Fuhr <mike(at)fuhr(dot)org>
To: pgsql-patches(at)postgresql(dot)org
Subject: PL/Perl embedding string common elements
Date: 2005-08-20 19:35:57
Message-ID: 20050820193557.GA77080@winnie.fuhr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The attached patch moves the common elements of loose_embedding[]
and strict_embedding[] to a macro so they can be maintained in
one place. As Tom Lane noticed, ::_plperl_to_pg_array was missing
from strict_embedding[], which appears to be a bug.

http://archives.postgresql.org/pgsql-bugs/2005-08/msg00189.php

I'm not sure this patch meets Tom's request to avoid "too much
violence to the readability," mostly because of the added backslashes
at the end of the macro's lines. Opinions?

--
Michael Fuhr

Attachment Content-Type Size
plperl-embedding.patch text/plain 2.8 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Fuhr 2005-08-20 19:52:42 PL/Perl regression tests with use_strict
Previous Message Andrew Dunstan 2005-08-20 19:30:07 Re: PL/Perl namespace fix