Quick Links

pgsql: The large one adds support for RSA keys and reorganizes the

From:	momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To:	pgsql-committers(at)postgresql(dot)org
Subject:	pgsql: The large one adds support for RSA keys and reorganizes the
Date:	2005-08-13 02:06:22
Message-ID:	20050813020622.0D63752BD5@svr1.postgresql.org
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-committers

Log Message:
-----------
The large one adds support for RSA keys and reorganizes
the pubkey functions a bit. The actual RSA-specific code
there is tiny, most of the patch consists of reorg of the
pubkey code, as lots of it was written as elgamal-only.

---------------------------------------------------------------------------

The SHLIB section was copy-pasted from somewhere and contains
several unnecessary libs. This cleans it up a bit.

-lcrypt
we don't use system crypt()

-lssl, -lssleay32
no SSL here

-lz in win32 section
already added on previous line

-ldes
The chance anybody has it is pretty low.
And the chance pgcrypto works with it is even lower.

Also trim the win32 section.

---------------------------------------------------------------------------

It is already disabled in Makefile, remove code too.

---------------------------------------------------------------------------

I was bit hasty making the random exponent 'k' a prime. Further researh
shows that Elgamal encryption has no specific needs in respect to k,
any random number is fine.

It is bit different for signing, there it needs to be 'relatively prime'
to p - 1, that means GCD(k, p-1) == 1, which is also a lot lighter than
full primality. As we don't do signing, this can be ignored.

This brings major speedup to Elgamal encryption.

---------------------------------------------------------------------------

o pgp_mpi_free: Accept NULLs
o pgp_mpi_cksum: result should be 16bit
o Remove function name from error messages - to be similar to other
SQL functions, and it does not match anyway the called function
o remove couple junk lines

---------------------------------------------------------------------------

o Support for RSA encryption
o Big reorg to better separate generic and algorithm-specific code.
o Regression tests for RSA.

---------------------------------------------------------------------------

o Tom stuck a CVS id into file. I doubt the usefulness of it,
but if it needs to be in the file then rather at the end.
Also tag it as comment for asciidoc.
o Mention bytea vs. text difference
o Couple clarifications

---------------------------------------------------------------------------

There is a choice whether to update it with pgp functions or
remove it. I decided to remove it, updating is pointless.

I've tried to keep the core of pgcrypto relatively independent
from main PostgreSQL, to make it easy to use externally if needed,
and that is good. Eg. that made development of PGP functions much
nicer.

But I have no plans to release it as generic library, so keeping such
doc
up-to-date is waste of time. If anyone is interested in using it in
other products, he can probably bother to read the source too.

Commented source is another thing - I'll try to make another pass
over code to see if there is anything non-obvious that would need
more comments.

---------------------------------------------------------------------------

Marko Kreen

Browse pgsql-committers by date

	From	Date	Subject
Next Message	Bruce Momjian	2005-08-13 02:48:24	pgsql: CREATE TABLE has optional column names, so change {} to [].
Previous Message	Bruce Momjian	2005-08-13 01:55:42	pgsql: Add documentation: >>>I think a more accurate description would