Re: [HACKERS] For review: Server instrumentation patch

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] For review: Server instrumentation patch
Date: 2005-08-11 17:39:17
Message-ID: 20050811173917.GA21939@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, Aug 11, 2005 at 01:19:29PM -0400, Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > So, did you try
> >
> > select * from pg_file_stats('postgresql.conf');
>
> Yes, I got:
>
> ERROR: a column definition list is required for functions returning "record"

Interesting. I wonder why the function is not defined instead with OUT
parameters. That way you don't have to declare the record at execution
time. See my patch to pgstattuple for an example.

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"No es bueno caminar con un hombre muerto"

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-08-11 18:26:16 Re: [HACKERS] For review: Server instrumentation patch
Previous Message Bruce Momjian 2005-08-11 17:19:29 Re: [HACKERS] For review: Server instrumentation patch