Re: [HACKERS] For review: Server instrumentation patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] For review: Server instrumentation patch
Date: 2005-08-11 15:34:43
Message-ID: 200508111534.j7BFYhC09540@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andreas Pflug wrote:
> Bruce Momjian wrote:
> > Dave Page wrote:
> >
> >
> > The only part I didn't like about the patch is the stat display:
> >
> > test=> select pg_file_stat('postgresql.conf');
> > pg_file_stat
> > -----------------------------------------------------------------------------
> >
> > (12287,"2005-08-11 00:06:30","2005-08-11 00:06:43","2005-08-11 00:06:30",f)
> > (1 row)
> >
> > Shouldn't this return multiple labeled columns rather than an array?
>
> pg_show_all_settings output is equally unreadable, designed not to be
> used directly.

True, but we have SELECT * FROM pg_settings() that does display the
titles. Right now the values aren't even documented.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2005-08-11 16:32:39 Re: [HACKERS] For review: Server instrumentation patch
Previous Message Andreas Pflug 2005-08-11 15:32:47 Re: [HACKERS] For review: Server instrumentation patch