From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: --enable-thread-safety on Win32 |
Date: | 2005-07-28 15:08:12 |
Message-ID: | 200507281508.j6SF8Cs28302@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> writes:
> > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> >> I would like to see how hard it would be to
> >> add #ifdefs to get the test program to run on Win32.
>
> > I did manage to get it to compile (though not work fully just yet),
> > however I had to use the full pthreads library rather than our minimal
> > implementation. That's why I question whether we should go this way - an
> > extra dependency (pthreads is not normally on a Windows box, even with
> > Msys) to test an OS that we know 100% for sure is not going to vary in
> > it's thread-safetyness(!) from system to system.
>
> I agree --- that seems like useless make-work. Just put a special case
> for Windows into configure.in and be done with it.
OK, but I would then like someone to actually run the tests we do in
thread_test.c and make sure they _would_ pass on Win32.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2005-07-28 15:16:27 | Re: --enable-thread-safety on Win32 |
Previous Message | Tom Lane | 2005-07-28 14:44:36 | Re: --enable-thread-safety on Win32 |