Re: For review: Server instrumentation patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: For review: Server instrumentation patch
Date: 2005-07-23 19:01:10
Message-ID: 200507231901.j6NJ1Ax24731@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


This patch looks good. The only question I have is why you didn't want
the pgport rename/unlink calls? We usually use them unless there is
some reason not to.

---------------------------------------------------------------------------

Dave Page wrote:
>
> [Resent as the list seems to have rejected yesterdays attempt]
>
> As per Bruce's request, here's a copy of Andreas' server
> instrumentation patch for review. I've separated out the
> dbsize stuff and pg_terminate_backend is also not included.
>
> This version was generated against CVS today.
>
> As far as I can tell from review of comments made back to
> pre-8.0, all security and other concerns raised have been addressed.
>
> Regards, Dave.

Content-Description: instrumentation.tar.gz

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-07-23 19:02:04 regression failure on stats test
Previous Message Bruce Momjian 2005-07-23 18:51:16 Re: [HACKERS] regressin failure on latest CVS

Browse pgsql-patches by date

  From Date Subject
Next Message Rocco Altier 2005-07-23 19:06:47 Re: [HACKERS] regressin failure on latest CVS
Previous Message Bruce Momjian 2005-07-23 18:51:16 Re: [HACKERS] regressin failure on latest CVS