Re: [PATCHES] thousands comma numeric formatting in psql

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Eugen Nedelcu <eugen(at)sifolt(dot)ro>
Subject: Re: [PATCHES] thousands comma numeric formatting in psql
Date: 2005-07-12 07:26:49
Message-ID: 200507120926.50013.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Am Dienstag, 12. Juli 2005 05:29 schrieb Bruce Momjian:
> > Bruce Momjian wrote:
> > > I have heavily modified your patch and have applied it. Instead of
> > > using langinfo, I used a \pset variable numericsep.

> Because I don't have langinfo on my system, so I can't test it, nor add
> configure code for it. It also prevents us from using space as the
> separator, which is the international standard.

OK, so let's discuss what we really want here.

The original submitter wanted locale-dependent output, which seems reasonable,
because that's what locale settings are intended for.

The current state allows users to manually set the format, or actually only
one aspect of the format? Where can you set the decimal separator and the
size of the grouping (3 digits or 4 digits)? Is this capability even useful
to get localized behavior?

My other concern is that if we allow manual specification of the output format
of some data type, then eventually someone will want to specify the format of
some other data type as well, such as the date/time types. We should think
about whether we want to be consistent here.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2005-07-12 07:28:17 Re: 4 pgcrypto regressions failures - 1 unsolved
Previous Message Junji TERAMOTO 2005-07-12 07:01:55 Re: Quick-and-dirty compression for WAL backup blocks

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2005-07-12 07:28:17 Re: 4 pgcrypto regressions failures - 1 unsolved
Previous Message Bruce Momjian 2005-07-12 03:29:20 Re: thousands comma numeric formatting in psql