Re: [HACKERS] Problem with dblink regression test - FIXED

On Tue, Jun 28, 2005 at 02:28:11PM -0400, Andrew Dunstan wrote:
>
>
> Jim C. Nasby wrote:
>
> >All the logs for the most recent run against HEAD are now at
> >http://stats.distributed.net/~buildfarm/
> >
> >
> >
> >
>
> A quick look shows that when you use --with-libraries=/foo/bar the
> generated link line for libraries says
>
> -L/foo/bar -lpq
>
> and it should probably be the other way around (as it is for the
> executables).
>
> So I suspect we need some makefile tuning.

You were correct. This patch fixes it:
Index: Makefile.shlib
===================================================================
RCS file: /projects/cvsroot/pgsql/src/Makefile.shlib,v
retrieving revision 1.90
diff -c -r1.90 Makefile.shlib
*** Makefile.shlib 20 Nov 2004 21:13:04 -0000 1.90
--- Makefile.shlib 29 Jun 2005 00:21:10 -0000
***************
*** 240,246 ****
SHLIB_LINK += -ltermcap -lstdc++.r4 -lbind -lsocket -L/boot/develop/lib/x86
endif

! SHLIB_LINK := $(filter -L%, $(LDFLAGS)) $(SHLIB_LINK)
ifeq ($(enable_rpath), yes)
SHLIB_LINK += $(rpath)
endif
--- 240,246 ----
SHLIB_LINK += -ltermcap -lstdc++.r4 -lbind -lsocket -L/boot/develop/lib/x86
endif

! SHLIB_LINK := $(SHLIB_LINK) $(filter -L%, $(LDFLAGS))
ifeq ($(enable_rpath), yes)
SHLIB_LINK += $(rpath)
endif

--
Jim C. Nasby, Database Consultant decibel(at)decibel(dot)org
Give your computer some brain candy! www.distributed.net Team #1828

Windows: "Where do you want to go today?"
Linux: "Where do you want to go tomorrow?"
FreeBSD: "Are you guys coming, or what?"