pgsql: exec_eval_datum leaks memory when dealing with ROW or REC values.

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: exec_eval_datum leaks memory when dealing with ROW or REC values.
Date: 2005-06-20 22:51:29
Message-ID: 20050620225129.1A75452839@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
exec_eval_datum leaks memory when dealing with ROW or REC values.
It never leaked memory before PG 8.0, so none of the callers are
expecting this. Cleanest fix seems to be to make it allocate the needed
memory in estate->eval_econtext, where it will be cleaned up by
the next exec_eval_cleanup. Per report from Bill Rugolsky.

Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
pl_exec.c (r1.145 -> r1.146)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c.diff?r1=1.145&r2=1.146)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-06-20 22:51:49 pgsql: exec_eval_datum leaks memory when dealing with ROW or REC values.
Previous Message User Diogob 2005-06-20 22:49:44 dblink-tds - dblink_tds: add create view function