Re: [PATCHES] Escape handling in strings

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Rod Taylor <pg(at)rbt(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Subject: Re: [PATCHES] Escape handling in strings
Date: 2005-06-17 04:22:41
Message-ID: 200506170422.j5H4MgP08319@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, the current patch warns about two things, \' with one message, and
> > any backslash in a non-E string with a different message.
>
> Those are two very different things. \' is easy to get around and
> there's no very good reason not to send '' instead. But avoiding all
> use of \anything is impossible (think \\) so a non-suppressable warning
> for that would be quite unacceptable IMHO. I think it's much too early
> to be throwing a warning for \anything anyway. 8.2 or so, OK, but not
> in this cycle.

I am concerned we are going to generate confusing if we warn about one
use of backslashes in strings but not another. I am thinking we will
just add the infrastructure for E'' in 8.1 (with the warning turned
off), and state we will warn about all backslashes in non-E strings in
8.2, and maybe go for literal strings in 8.3 or 8.4 depending on user
feedback.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas F. O'Connell 2005-06-17 04:55:34 Re: Autovacuum in the backend
Previous Message Tom Lane 2005-06-17 03:33:54 Re: [PATCHES] Escape handling in strings

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Glaesemann 2005-06-17 05:09:50 Re: [PATCHES] Escape handling in strings
Previous Message Tom Lane 2005-06-17 03:33:54 Re: [PATCHES] Escape handling in strings