Re: [HACKERS] Continue transactions after errors in psql

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Richard Huxton <dev(at)archonet(dot)com>, Michael Paesold <mpaesold(at)gmx(dot)at>, Greg Sabino Mullane <greg(at)turnstep(dot)com>
Subject: Re: [HACKERS] Continue transactions after errors in psql
Date: 2005-04-28 03:46:15
Message-ID: 200504280346.j3S3kFt25488@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

pgman wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Tom Lane wrote:
> > >> Well, that's just a matter of choosing good (ie short) names for the
> > >> backslash commands. I was trying to be clear rather than proposing
> > >> names I would actually want to use ;-). Any suggestions?
> >
> > > Well, if we allowed ON_ERROR_ROLLBACK to work in non-interactive
> > > sessions we could just do:
> >
> > > \set ON_ERROR_ROLLBACK on
> > > DROP TABLE foo;
> > > \set ON_ERROR_ROLLBACK off
> >
> > That isn't the same thing at all. The syntax I was proposing allows the
> > script writer to define a savepoint covering multiple statements,
> > whereas the above does not.
>
> Well, it fits the use case posted, that is to conditionally roll back a
> _single_ failed query. I don't see the need to add a new
> infrastructure/command unless people have a use case for rolling back a
> group of statements on failure. I have no seen such a description yet.

OK, updated patch that allows for 'on/interactive/off'. Seems there are
enough use cases to add an 'interactive' option.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 5.2 KB

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-04-28 13:02:40 Feature freeze date for 8.1
Previous Message Tom Lane 2005-04-27 23:05:40 Re: [PATCHES] [WIP] shared locks