Re: Updated FSM display for VACUUM VERBOSE

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Updated FSM display for VACUUM VERBOSE
Date: 2005-04-23 18:13:06
Message-ID: 200504231813.j3NID6h27780@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I have simplified the patch. It doesn't use any new computations
> > but just displays them differently. The output is now:
>
> > INFO: free space map contains information about:
> > INFO: 49 relations, limit 1000 relations
> > INFO: 35 pages with free space, 784 pages (with overhead)
> > INFO: 784 pages required to track all freespace, limit 18000 pages (171 kB)
>
> This breaks the message style guidelines in a number of ways, and I
> don't find it clear at all.

OK, what suggestions do you have, and how did I break the style
guidelines?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-04-23 18:52:16 Re: revise a comment in CreateCheckPoint()
Previous Message Tom Lane 2005-04-23 18:01:49 Re: Updated FSM display for VACUUM VERBOSE