Re: [pgsql-hackers-win32] win32 performance - fsync question

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, Michael Paesold <mpaesold(at)gmx(dot)at>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org, Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>
Subject: Re: [pgsql-hackers-win32] win32 performance - fsync question
Date: 2005-03-17 18:53:11
Message-ID: 200503171853.j2HIrBk08017@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > However, I do prefer this patch and let Win32 have the same write cache
> > issues as Unix, for consistency.
>
> I agree that the open flag is more nearly O_DSYNC than O_SYNC.
>
> ISTM Windows' idea of fsync is quite different from Unix's and therefore
> we should name the wal_sync_method that invokes it something different
> than fsync. "write_through" or some such? We already have precedent
> that not all wal_sync_method values are available on all platforms.
>
> I'm not taking a position on which the default should be ...

Yes, I am thinking that too. I hesistated because it adds yet another
sync method, and we have to document it works only on Win32, but I see
no better solution.

I am going to let the Win32 users mostly vote on what the default should
be.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-03-17 19:02:29 Re: [pgsql-hackers-win32] win32 performance - fsync question
Previous Message Mark Woodward 2005-03-17 18:47:40 Re: PHP stuff

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2005-03-17 19:02:29 Re: [pgsql-hackers-win32] win32 performance - fsync question
Previous Message Bruce Momjian 2005-03-17 18:42:56 Re: Changing the default wal_sync_method to open_sync for

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-03-17 19:02:29 Re: [pgsql-hackers-win32] win32 performance - fsync question
Previous Message Tom Lane 2005-03-17 18:41:00 Re: [pgsql-hackers-win32] win32 performance - fsync question